Metarefresh module should add requested attribute values to PHP metadata when adding requested attributes

[kwessel]

Is your feature request related to a problem? Please describe.

XML metadata supports not only specifiying an SP's requested attributes, but also specific values of those attributes:

    <RequestedAttribute FriendlyName="eduPersonEntitlement" Name="urn:oid:1.3.6.1.4.1.5923.1.1.1.7" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" isRequired="true">                                                         
      <saml:AttributeValue xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">urn:mace:incommon:uiuc.edu:some:value</saml:AttributeValue>                                                                                                    
    </RequestedAttribute>

Currently, the metarefresh module includes the requested attributes in the generated PHP metadata, but not the requested values:

'attributes' => [
    'urn:oid:1.3.6.1.4.1.5923.1.1.1.7',
]

It should generate this instead:

'attributes' => [
    'urn:oid:1.3.6.1.4.1.5923.1.1.1.7' => [ ' urn:mace:incommon:uiuc.edu:some:value'
]

[ghalse]

This is not actually an error in simplesamlphp-module-metarefresh. It's a shortcoming of the underlying SAMLParser class that parses the XML. Fixes for it exist in simplesamlphp/simplesamlphp#2581 (master) and simplesamlphp/simplesamlphp#2582 (simplesamlphp-2.5).

This can probably be closed once those changes are made.