-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Implement correlation on event filter #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -355,6 +355,11 @@ public <T> T addMetadataIfAbsent(String key, Supplier<T> supplier) { | |||||
| return (T) additionalObjects.computeIfAbsent(key, k -> supplier.get()); | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public void removeMetadataIfPresent(String key) { | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| additionalObjects.remove(key); | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public <T> Optional<T> findMetadata(String key, Class<T> objectClass) { | ||||||
| Object value = additionalObjects.get(key); | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,12 +16,16 @@ | |||||
| package io.serverlessworkflow.impl.events; | ||||||
|
|
||||||
| import io.cloudevents.CloudEvent; | ||||||
| import io.serverlessworkflow.api.types.CorrelateProperty; | ||||||
| import io.serverlessworkflow.api.types.EventFilter; | ||||||
| import io.serverlessworkflow.api.types.EventFilterCorrelate; | ||||||
| import io.serverlessworkflow.api.types.EventProperties; | ||||||
| import io.serverlessworkflow.impl.TaskContext; | ||||||
| import io.serverlessworkflow.impl.WorkflowApplication; | ||||||
| import io.serverlessworkflow.impl.WorkflowContext; | ||||||
| import io.serverlessworkflow.impl.WorkflowModel; | ||||||
| import java.util.AbstractCollection; | ||||||
| import java.util.ArrayList; | ||||||
| import java.util.Collection; | ||||||
| import java.util.Iterator; | ||||||
| import java.util.List; | ||||||
|
|
@@ -37,6 +41,8 @@ public abstract class AbstractTypeConsumer | |||||
|
|
||||||
| private static final Logger logger = LoggerFactory.getLogger(AbstractTypeConsumer.class); | ||||||
|
|
||||||
| private static final CloudEventPredicate ALWAYS_TRUE = (ce, wf, t) -> true; | ||||||
|
|
||||||
| protected abstract void registerToAll(Consumer<CloudEvent> consumer); | ||||||
|
|
||||||
| protected abstract void unregisterFromAll(); | ||||||
|
|
@@ -52,13 +58,32 @@ public TypeEventRegistrationBuilder listen( | |||||
| EventFilter register, WorkflowApplication application) { | ||||||
| EventProperties properties = register.getWith(); | ||||||
| String type = properties.getType(); | ||||||
| return new TypeEventRegistrationBuilder( | ||||||
| type, application.cloudEventPredicateFactory().build(application, properties)); | ||||||
| CloudEventPredicate cePredicate = | ||||||
| application.cloudEventPredicateFactory().build(application, properties); | ||||||
| Collection<CloudEventPredicate> correlationPredicates = | ||||||
| buildCorrelationPredicates(register.getCorrelate(), application); | ||||||
| return new TypeEventRegistrationBuilder(type, cePredicate, correlationPredicates); | ||||||
| } | ||||||
|
|
||||||
| private Collection<CloudEventPredicate> buildCorrelationPredicates( | ||||||
| EventFilterCorrelate correlate, WorkflowApplication application) { | ||||||
| if (correlate == null) { | ||||||
| return List.of(); | ||||||
| } | ||||||
| Map<String, CorrelateProperty> additionalProperties = correlate.getAdditionalProperties(); | ||||||
| if (additionalProperties == null || additionalProperties.isEmpty()) { | ||||||
| return List.of(); | ||||||
| } | ||||||
| Collection<CloudEventPredicate> predicates = new ArrayList<>(); | ||||||
| for (Map.Entry<String, CorrelateProperty> entry : additionalProperties.entrySet()) { | ||||||
| predicates.add(CorrelationPredicate.from(entry.getKey(), entry.getValue(), application)); | ||||||
| } | ||||||
|
matheusandre1 marked this conversation as resolved.
|
||||||
| return predicates; | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public Collection<TypeEventRegistrationBuilder> listenToAll(WorkflowApplication application) { | ||||||
| return List.of(new TypeEventRegistrationBuilder(null, null)); | ||||||
| return List.of(new TypeEventRegistrationBuilder(null, ALWAYS_TRUE, List.of())); | ||||||
| } | ||||||
|
|
||||||
| private static class CloudEventConsumer extends AbstractCollection<TypeEventRegistration> | ||||||
|
|
@@ -68,11 +93,42 @@ private static class CloudEventConsumer extends AbstractCollection<TypeEventRegi | |||||
| @Override | ||||||
| public void accept(CloudEvent ce) { | ||||||
| logger.debug("Received cloud event {}", ce); | ||||||
| WorkflowModel eventModel = null; | ||||||
| for (TypeEventRegistration registration : registrations) { | ||||||
| if (registration.predicate().test(ce, registration.workflow(), registration.task())) { | ||||||
| registration.consumer().accept(ce); | ||||||
| if (!registration.predicate().test(ce, registration.workflow(), registration.task())) { | ||||||
| continue; | ||||||
| } | ||||||
| Collection<CloudEventPredicate> correlationPredicates = | ||||||
| registration.correlationPredicates(); | ||||||
| if (!correlationPredicates.isEmpty()) { | ||||||
| if (eventModel == null | ||||||
| && correlationPredicates.stream() | ||||||
| .anyMatch(ModelAwareCloudEventPredicate.class::isInstance)) { | ||||||
| eventModel = registration.workflow().definition().application().modelFactory().from(ce); | ||||||
| } | ||||||
| if (!testCorrelation(ce, registration, eventModel)) { | ||||||
| continue; | ||||||
| } | ||||||
| } | ||||||
| registration.consumer().accept(ce); | ||||||
| } | ||||||
| } | ||||||
|
matheusandre1 marked this conversation as resolved.
fjtirado marked this conversation as resolved.
fjtirado marked this conversation as resolved.
|
||||||
|
|
||||||
| private boolean testCorrelation( | ||||||
| CloudEvent ce, TypeEventRegistration registration, WorkflowModel eventModel) { | ||||||
| Collection<CloudEventPredicate> predicates = registration.correlationPredicates(); | ||||||
| for (CloudEventPredicate pred : predicates) { | ||||||
| if (pred instanceof ModelAwareCloudEventPredicate ma) { | ||||||
| if (!ma.test(eventModel, registration.workflow(), registration.task())) { | ||||||
| return false; | ||||||
|
fjtirado marked this conversation as resolved.
|
||||||
| } | ||||||
| } else { | ||||||
| if (!pred.test(ce, registration.workflow(), registration.task())) { | ||||||
| return false; | ||||||
| } | ||||||
|
matheusandre1 marked this conversation as resolved.
|
||||||
| } | ||||||
| } | ||||||
| return true; | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
|
|
@@ -104,10 +160,16 @@ public TypeEventRegistration register( | |||||
| TaskContext task) { | ||||||
| if (builder.type() == null) { | ||||||
| registerToAll(ce); | ||||||
| return new TypeEventRegistration(null, ce, null, workflow, task); | ||||||
| return new TypeEventRegistration(null, ce, ALWAYS_TRUE, workflow, task); | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know the AI was complaining, but this was not really needed, since the predicate was not used for all registration scenario and it was null on purpose. |
||||||
| } else { | ||||||
| TypeEventRegistration registration = | ||||||
| new TypeEventRegistration(builder.type(), ce, builder.cePredicate(), workflow, task); | ||||||
| new TypeEventRegistration( | ||||||
| builder.type(), | ||||||
| ce, | ||||||
| builder.cePredicate(), | ||||||
| builder.correlationPredicates(), | ||||||
| workflow, | ||||||
| task); | ||||||
| registrations | ||||||
| .computeIfAbsent( | ||||||
| registration.type(), | ||||||
|
|
@@ -138,5 +200,17 @@ public void unregister(TypeEventRegistration registration) { | |||||
| } | ||||||
| }); | ||||||
| } | ||||||
| cleanupCorrelationState(registration); | ||||||
| } | ||||||
|
|
||||||
| private void cleanupCorrelationState(TypeEventRegistration registration) { | ||||||
| for (CloudEventPredicate pred : registration.correlationPredicates()) { | ||||||
| if (pred instanceof CorrelationPredicate cp) { | ||||||
| String key = cp.stateKey(registration.task()); | ||||||
| if (key != null) { | ||||||
| registration.workflow().instance().removeMetadataIfPresent(key); | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
matheusandre1 marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Copyright 2020-Present The Serverless Workflow Specification Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.serverlessworkflow.impl.events; | ||
|
|
||
| import io.cloudevents.CloudEvent; | ||
| import io.serverlessworkflow.api.types.CorrelateProperty; | ||
| import io.serverlessworkflow.impl.TaskContext; | ||
| import io.serverlessworkflow.impl.WorkflowApplication; | ||
| import io.serverlessworkflow.impl.WorkflowContext; | ||
| import io.serverlessworkflow.impl.WorkflowModel; | ||
| import io.serverlessworkflow.impl.WorkflowValueResolver; | ||
| import io.serverlessworkflow.impl.expressions.ExpressionDescriptor; | ||
| import java.util.Objects; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| class CorrelationPredicate implements ModelAwareCloudEventPredicate { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(CorrelationPredicate.class); | ||
|
|
||
| private final String correlationKey; | ||
| private final WorkflowValueResolver<Object> fromResolver; | ||
| private final WorkflowValueResolver<Object> expectResolver; | ||
|
|
||
| private CorrelationPredicate( | ||
| String correlationKey, | ||
| WorkflowValueResolver<Object> fromResolver, | ||
| WorkflowValueResolver<Object> expectResolver) { | ||
| this.correlationKey = correlationKey; | ||
| this.fromResolver = fromResolver; | ||
| this.expectResolver = expectResolver; | ||
| } | ||
|
|
||
| public static CorrelationPredicate from( | ||
| String key, CorrelateProperty prop, WorkflowApplication app) { | ||
| WorkflowValueResolver<Object> fromResolver = | ||
| app.expressionFactory().resolveValue(ExpressionDescriptor.from(prop.getFrom())); | ||
| WorkflowValueResolver<Object> expectResolver = | ||
| prop.getExpect() != null | ||
| ? app.expressionFactory().resolveValue(ExpressionDescriptor.from(prop.getExpect())) | ||
| : null; | ||
| return new CorrelationPredicate(key, fromResolver, expectResolver); | ||
| } | ||
|
|
||
| private String correlationStateKey(TaskContext task) { | ||
| return "correlation:" | ||
| + task.position().jsonPointer() | ||
| + ":" | ||
| + task.iteration() | ||
| + ":" | ||
| + correlationKey; | ||
| } | ||
|
matheusandre1 marked this conversation as resolved.
|
||
|
|
||
| String stateKey(TaskContext task) { | ||
| return expectResolver == null ? correlationStateKey(task) : null; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean test(CloudEvent cloudEvent, WorkflowContext workflow, TaskContext task) { | ||
|
matheusandre1 marked this conversation as resolved.
|
||
| WorkflowModel eventModel = workflow.definition().application().modelFactory().from(cloudEvent); | ||
| return test(eventModel, workflow, task); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean test(WorkflowModel eventModel, WorkflowContext workflow, TaskContext task) { | ||
| Object eventValue = fromResolver.apply(workflow, task, eventModel); | ||
|
matheusandre1 marked this conversation as resolved.
|
||
| if (eventValue == null) { | ||
| logger.debug("Correlation from expression returned null"); | ||
| return false; | ||
| } | ||
|
matheusandre1 marked this conversation as resolved.
|
||
|
|
||
| if (expectResolver == null) { | ||
| String stateKey = correlationStateKey(task); | ||
| Object firstValue = workflow.instance().addMetadataIfAbsent(stateKey, () -> eventValue); | ||
|
matheusandre1 marked this conversation as resolved.
|
||
| boolean result = Objects.equals(eventValue, firstValue); | ||
| logger.debug( | ||
| "Correlation no expect, eventValue='{}', firstValue='{}', match={}", | ||
| eventValue, | ||
| firstValue, | ||
| result); | ||
| return result; | ||
| } | ||
|
matheusandre1 marked this conversation as resolved.
|
||
|
|
||
| Object expectedValue = expectResolver.apply(workflow, task, task.input()); | ||
| boolean result = Objects.equals(eventValue, expectedValue); | ||
|
matheusandre1 marked this conversation as resolved.
|
||
| logger.debug( | ||
| "Correlation eventValue='{}', expectedValue='{}', match={}", | ||
| eventValue, | ||
| expectedValue, | ||
| result); | ||
| return result; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.