From fb681038016d45e12ec2de01ad2a5fb92ff98ea7 Mon Sep 17 00:00:00 2001 From: Gabriel <10530980+gpotter2@users.noreply.github.com> Date: Tue, 14 Apr 2026 00:40:10 +0200 Subject: [PATCH 1/2] Users should disclose the use of AI --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a7340ee6c6b..e7c2b29085b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,6 +7,9 @@ - [ ] I added unit tests or explained why they are not relevant - [ ] I executed the regression tests (using `tox`) - [ ] If the PR is still not finished, please create a [Draft Pull Request](https://github.blog/2019-02-14-introducing-draft-pull-requests/) +- [ ] This PR uses (partially) AI-generated code: Yes/No + +**Failing to mention the use of AI may result in a ban. We do not forbid it, but you must play fair. Be warned !** From 42072c7331e3c17f528725e38a29b612ca2944d7 Mon Sep 17 00:00:00 2001 From: Gabriel <10530980+gpotter2@users.noreply.github.com> Date: Sat, 18 Apr 2026 14:28:07 +0200 Subject: [PATCH 2/2] Revise PR template for clarity and AI code usage Updated the pull request template to clarify the checklist items and AI-generated code usage. --- .github/PULL_REQUEST_TEMPLATE.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e7c2b29085b..51acbea8a29 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,20 @@ - + -**Checklist:** +**Checklist :** - [ ] If you are new to Scapy: I have checked [CONTRIBUTING.md](https://github.com/secdev/scapy/blob/master/CONTRIBUTING.md) (esp. section submitting-pull-requests) - [ ] I squashed commits belonging together - [ ] I added unit tests or explained why they are not relevant - [ ] I executed the regression tests (using `tox`) - [ ] If the PR is still not finished, please create a [Draft Pull Request](https://github.blog/2019-02-14-introducing-draft-pull-requests/) -- [ ] This PR uses (partially) AI-generated code: Yes/No +- [ ] This PR uses (partially) AI-generated code. If so: + - [ ] I ensured the generated code follows the internal concepts of scapy + - [ ] This PR has a test coverage > 90% + - [ ] I reviewed every generated line + - [ ] If this PR contains more than 500 lines of code (excluding unit tests) I considered splitting this PR. + - [ ] I considered interoperability tests with existing packages or utilities to ensure conformity of a newly generated protocol -**Failing to mention the use of AI may result in a ban. We do not forbid it, but you must play fair. Be warned !** +**I understand that failing to mention the use of AI may result in a ban. (We do not forbid it, but you must play fair. Be warned !)**