fix: replace deprecated pkg_resources namespace declaration#131
Open
Tranquil-Flow wants to merge 1 commit into
Open
fix: replace deprecated pkg_resources namespace declaration#131Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated
pkg_resources.declare_namespace()namespace declaration inlark_oapi/ws/pb/google/__init__.pywith the existingpkgutil.extend_path()fallback path.Why
Importing this module currently emits:
In newer setuptools environments, this can become a hard import failure when
pkg_resources.declare_namespaceis unavailable.Notes
This is the same minimal approach as PR #124, but that PR is currently blocked by CLA because its commit author email is not associated with a GitHub user. Opening this replacement so the fix has an unblocked path to merge.
Fixes #108.
Refs #115.
Refs #124.
Verification
Ran a minimal import proof with warnings treated as errors: