From 885064505abd3a1859245bde2dc2d66b44433d4b Mon Sep 17 00:00:00 2001 From: Cocoon-Break <54054995+kuishou68@users.noreply.github.com> Date: Sun, 19 Apr 2026 09:35:09 +0800 Subject: [PATCH] fix(a2a): set final=True for error TaskStatusUpdateEvent in event_converter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a task transitions to TaskState.failed, the resulting TaskStatusUpdateEvent should have final=True because the error state is terminal — no further events will follow. The existing from_adk_event.py already sets final=True for error events (line 154), but event_converter.py incorrectly uses final=False, which causes consumers to wait indefinitely for additional events after a failure. Closes #5388 Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com> --- src/google/adk/a2a/converters/event_converter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/google/adk/a2a/converters/event_converter.py b/src/google/adk/a2a/converters/event_converter.py index e6a890941f..bcdb46035b 100644 --- a/src/google/adk/a2a/converters/event_converter.py +++ b/src/google/adk/a2a/converters/event_converter.py @@ -461,7 +461,7 @@ def _create_error_status_event( platform_time.get_time(), tz=timezone.utc ).isoformat(), ), - final=False, + final=True, )