Skip to content

Fix security-related issues in github actions flagged by zizmor#21

Open
peytondmurray wants to merge 1 commit into
bloomberg:mainfrom
peytondmurray:18-harden-gh-actions
Open

Fix security-related issues in github actions flagged by zizmor#21
peytondmurray wants to merge 1 commit into
bloomberg:mainfrom
peytondmurray:18-harden-gh-actions

Conversation

@peytondmurray
Copy link
Copy Markdown

Issue number of the reported bug or feature request:
Closes #18.

Describe your changes
This PR resolves security-related issues with the github actions flagged by zizmor, and adds zizmor as a github action to ensure we don't introduce new security vulnerabilities in the future.

I also removed the PYTHON=... in the make lint call. There is no matrix.python-version variable, so this wasn't doing anything.

Testing performed
Testing will be done as part of CI.

Signed-off-by: pdmurray <peynmurray@gmail.com>
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I suspect @godlygeek will want to rewrite the commit message. Also I wonder if we should add Dependabot here, given that the upload and download actions seem out of date to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix problems reported by zizmor

3 participants