Skip to content

DeprecationWarning in api_client and rest: getheader and getheaders #195

@sshishov

Description

@sshishov

Hi dear Xero team,

We are receiving the following warning from your codebase:

DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.6.0.
Instead access HTTPResponse.headers directly.

I have noticed the usage in files:

  • rest.py:48: return self.urllib3_response.getheaders()
  • rest.py:52: return self.urllib3_response.getheader(name, default)
  • api_client/__init__.py:221: return (return_data, response_data.status, response_data.getheaders())
  • api_client/__init__.py:604: content_disposition = response.getheader("Content-Disposition")
  • exceptions/__init__.py:38: return self.http_resp.getheaders() if self.http_resp else None

For being able to upgrade urllib3 it is very important to keep the codebase up-to-date. Could you please fix the issue.

Best regards,
Sergei

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions