Skip to content

feat(linux): s2idle: Document the mode selection logic#641

Merged
StaticRocket merged 3 commits into
TexasInstruments:masterfrom
DhruvaG2000:s2idle_mode_sel_v1
May 18, 2026
Merged

feat(linux): s2idle: Document the mode selection logic#641
StaticRocket merged 3 commits into
TexasInstruments:masterfrom
DhruvaG2000:s2idle_mode_sel_v1

Conversation

@DhruvaG2000
Copy link
Copy Markdown
Collaborator

Document the mode selection logic using the s2idle flow

Copy link
Copy Markdown
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to see if there are other places in the previous parts of the doc that can be updated or that the new info can loop into and consolidate.

Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Copy link
Copy Markdown
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I think that the QoS Latency Constraints and Mode Selection section needs to be fixed up to flow better and be a little more condensed.

Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
@kwillis01
Copy link
Copy Markdown
Contributor

Additionally, could you update the RTC + DDR section in pm_am62lx_low_power_modes.rst with the updated commands needed to enter RTC + DDR? Then you can point to this page from there if the user wants an indepth explanation on s2idle

@github-actions
Copy link
Copy Markdown

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst:537: (ERROR/3) Content block expected for the "note" directive; none found.
source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst:538: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.

Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
@github-actions
Copy link
Copy Markdown

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst:505: (ERROR/3) Content block expected for the "note" directive; none found.
source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst:506: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.

@DhruvaG2000 DhruvaG2000 changed the title [RFC] feat(linux): s2idle: Document the mode selection logic feat(linux): s2idle: Document the mode selection logic Apr 24, 2026
@DhruvaG2000 DhruvaG2000 marked this pull request as ready for review April 24, 2026 12:39
Copy link
Copy Markdown
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to put explicit instructions on how to enter RTC + DDR via s2idle (besides the constraint setting) in pm_am62lx_low_power_modes. It would give users a quick way to grab the instructions and go.

Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
@cshilwant
Copy link
Copy Markdown
Member

@DhruvaG2000 can you re-spin after checking comments from @kwillis01 @ti-scaria

@DhruvaG2000 DhruvaG2000 force-pushed the s2idle_mode_sel_v1 branch from f4ad757 to 2c5e7bd Compare May 12, 2026 10:08
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Comment thread source/linux/Foundational_Components/Power_Management/pm_psci_s2idle.rst Outdated
Document the mode selection logic using the s2idle flow

Signed-off-by: Dhruva Gole <d-gole@ti.com>
Add mention of the s2idle based mode selection being part of
low power mode support as of this release

Signed-off-by: Dhruva Gole <d-gole@ti.com>
Also removes myself from AM62X device owner. Add Scaria as another
PM component owner

Signed-off-by: Dhruva Gole <d-gole@ti.com>
@DhruvaG2000 DhruvaG2000 force-pushed the s2idle_mode_sel_v1 branch from 19bd7c0 to 34ae59d Compare May 13, 2026 11:47
@StaticRocket StaticRocket self-requested a review May 13, 2026 22:15
Copy link
Copy Markdown
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM! Thanks Dhruva for all the work you put in with s2idle and these docs!

@StaticRocket StaticRocket merged commit 046a5ad into TexasInstruments:master May 18, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.