From 874d4235e4432ba0e34214be8a1a8965ce9cb728 Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Mon, 20 Apr 2026 22:24:34 +1000 Subject: [PATCH 1/2] Fix invalid imbued gems appearing in list Support gems like Prismatic Burst of Summon Wisps are not valid imbued supports as they grant active skills --- src/Classes/GemSelectControl.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Classes/GemSelectControl.lua b/src/Classes/GemSelectControl.lua index 552cff7bd6..8bf45a5898 100644 --- a/src/Classes/GemSelectControl.lua +++ b/src/Classes/GemSelectControl.lua @@ -113,8 +113,8 @@ function GemSelectClass:PopulateGemList() local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1 if characterLevel >= levelRequirement or not matchLevel then if self.imbuedSelect then - -- Imbued dropdown only allows non-exceptional support gems. - if gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and not gemData.grantedEffect.plusVersionOf then + -- Imbued dropdown only allows non-exceptional support gems and supports that don't grant active skills + if gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and not gemData.grantedEffect.plusVersionOf and (not gemData.secondaryGrantedEffect or gemData.secondaryGrantedEffect.support) then self.gems["Default:" .. gemId] = gemData end else @@ -139,7 +139,7 @@ function GemSelectClass:FilterSupport(gemId, gemData) end if self.imbuedSelect then - return gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and self.sortCache.canSupport[gemId] + return self.sortCache.canSupport[gemId] end return (not gemData.grantedEffect.support From ae2e2fd7b358f6750c8c72e1bd7be0aac23a8cf2 Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Mon, 20 Apr 2026 22:40:51 +1000 Subject: [PATCH 2/2] Fix Cast on Crit and other secondary granted effects Secondary granted effects from supports like cast on crit or cast when damage taken weren't working as we were not adding the secondary granted effects --- src/Modules/CalcSetup.lua | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Modules/CalcSetup.lua b/src/Modules/CalcSetup.lua index 2a3d495a1d..cd68f9074b 100644 --- a/src/Modules/CalcSetup.lua +++ b/src/Modules/CalcSetup.lua @@ -1516,7 +1516,12 @@ function calcs.initEnv(build, mode, override, specEnv) end -- if the slot has an imbued support, add it as an ExtraSupport if build.skillsTab.imbuedSupportBySlot and build.skillsTab.imbuedSupportBySlot[slotName] and group.imbuedSupport then - addExtraSupports(nil, build.skillsTab.imbuedSupportBySlot[slotName], 1) + local imbuedSupport = build.skillsTab.imbuedSupportBySlot[slotName] + addExtraSupports(nil, imbuedSupport, 1) + local imbuedGemData = env.data.gems[env.data.gemForSkill[imbuedSupport]] + if imbuedGemData and imbuedGemData.secondaryGrantedEffect and imbuedGemData.secondaryGrantedEffect.support then + addExtraSupports(nil, imbuedGemData.secondaryGrantedEffect, 1) + end end for gemIndex, gemInstance in ipairs(group.gemList) do