Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.
This repository was archived by the owner on May 19, 2025. It is now read-only.

Type Error: firebase-app.ts #604

@Alonski

Description

@Alonski

Version info

e.g.
DEBUG: -------------------------------
DEBUG: Ember      : 3.16.0
DEBUG: Ember Data : 3.17.0
DEBUG: Firebase   : 7.7.0
DEBUG: EmberFire  : 3.0.0-rc.6
DEBUG: jQuery     : 0
DEBUG: -------------------------------

Test case

Steps to reproduce

  1. Install this addon in a new Ember Octane + Typescript app.
  2. Run Ember Serve/Builder and receive an error.

Expected behavior

No type error is thrown.

Actual behavior

This type error is thrown:

../../node_modules/emberfire/services/firebase-app.d.ts:14:5 - error TS2416: Property 'name' in type 'FirebaseAppService' is not assignable to the same property in base type '{ name: undefined; firebase: ComputedProperty<FirebaseService, FirebaseService>; } & Service & { name: undefined; firebase: ComputedProperty<...>; }'.
  Type 'string | undefined' is not assignable to type 'undefined'.
    Type 'string' is not assignable to type 'undefined'.

14     name?: string;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions