Thanks a lot for the script, it's great! But I stumbled across an issue:
The Bvh class member functions frame_joint_channel , frame_joint_channels and frames_joint_channels are all accepting a value argument, yet this argument can't do anything.
In line 148, 157, and 174 there's a check if channel_index == -1 and value is not None:, but channel_index can never be -1, because it's retrieved by self.joint_channels(joint).index(channel) which just throws a ValueError if it can't find channel (e.g. 'Zposition' is not in list), because index() is a simple list member function.
I guess that value was supposed to be a fallback value if the channel wasn't found and the idea was to do a similar check as in joint_parent_index, but was forgotten?
Thanks a lot for the script, it's great! But I stumbled across an issue:
The Bvh class member functions frame_joint_channel , frame_joint_channels and frames_joint_channels are all accepting a value argument, yet this argument can't do anything.
In line 148, 157, and 174 there's a check
if channel_index == -1 and value is not None:, but channel_index can never be -1, because it's retrieved byself.joint_channels(joint).index(channel)which just throws a ValueError if it can't find channel (e.g. 'Zposition' is not in list), because index() is a simple list member function.I guess that value was supposed to be a fallback value if the channel wasn't found and the idea was to do a similar check as in joint_parent_index, but was forgotten?